Fix: CLI Windows Write exe Errors
#3239
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DogeDark
added
bug
|
This is good for now, but a better solution to this problem might be:
When builds take a while it is nice to still have the app interactive. Hopefully one day our binary patching is good enough for most cases though. It might be worth it to gate the killall only on windows since mac/linux seem okay (and I think technically end up doing hotreloading automatically...) |
|
@jkelleyrtp If it sounds good to you, I will gate this behind Windows and I'll add the preferred fix into Notion for a future patch release so that it's ready for 0.6, but can be properly fixed when there is more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI fails to write the new executable on Windows because the old one is still running during rebuilds.
This PR introduces a
kill_all()method on theAppRunner. Ideally, the app would be killed right before the bundler starts, but I wasn't sure how to best get a handle down to the bundler. Instead, I opted for this simpler, but perhaps slightly less DX solution (since the app is closed during rebuilds and the dev can't admire their desktop app or interact with serverfns).